linux-kernel - Re: [PATCH 1/3] soc: qcom: rpmh-rsc: Remove tcs_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Apr 2020 10:21:53 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, Maulik Shah <mkshah@...eaurora.org>,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH 1/3] soc: qcom: rpmh-rsc: Remove tcs_is_free() API

Quoting Bjorn Andersson (2020-04-23 22:36:26)
> On Thu 23 Apr 21:54 PDT 2020, Stephen Boyd wrote:
> > diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> [..]
> >  static int find_free_tcs(struct tcs_group *tcs)
> >  {
> > -     int i;
> > +     const struct rsc_drv *drv = tcs->drv;
> > +     unsigned long i;
> >  
> > -     for (i = 0; i < tcs->num_tcs; i++) {
> > -             if (tcs_is_free(tcs->drv, tcs->offset + i))
> > -                     return tcs->offset + i;
> > -     }
> > +     i = find_next_zero_bit(drv->tcs_in_use, MAX_TCS_NR, tcs->offset);
> > +     if (i > tcs->offset + tcs->num_tcs)
> 
> Afaict this should be >=
> 

Thanks!