linux-kernel - Re: [PATCH v2 01/91] i2c: brcmstb: Allow to compile it on BCM2835

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200424190422.GA5220@kunai>
Date:   Fri, 24 Apr 2020 21:04:22 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Maxime Ripard <maxime@...no.tech>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Eric Anholt <eric@...olt.net>, dri-devel@...ts.freedesktop.org,
        linux-rpi-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Dave Stevenson <dave.stevenson@...pberrypi.com>,
        Tim Gover <tim.gover@...pberrypi.com>,
        Phil Elwell <phil@...pberrypi.com>,
        Kamal Dasu <kdasu.kdev@...il.com>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v2 01/91] i2c: brcmstb: Allow to compile it on BCM2835

On Fri, Apr 24, 2020 at 10:07:25AM -0700, Florian Fainelli wrote:
> 
> 
> On 4/24/2020 9:13 AM, Wolfram Sang wrote:
> > 
> >>  config I2C_BRCMSTB
> >>  	tristate "BRCM Settop/DSL I2C controller"
> >> -	depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
> >> -		   COMPILE_TEST
> >> +	depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC || \
> >> +		   ARCH_BCM_63XX || COMPILE_TEST
> > 
> > Isn't there something like ARCH_BROADCOM which we could use here instead
> > of adding each and every SoC?
> 
> If you are worried about this list growing bigger, I do not think this
> is going to happen beyond this changeset (famous last words).

Okay, thanks for the heads up.

I wonder, then, if the description after 'tristate' is still accurate?

But that withstanding, I am fine with this patch:

Acked-by: Wolfram Sang <wsa@...-dreams.de>

Let me know if I shall take this via I2C.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)