linux-kernel - Re: [PATCH] selftests: add build/cross-build dependency check script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <374866ac-4519-f367-bdc6-ec8d0c1b6347@infradead.org>
Date:   Thu, 23 Apr 2020 20:25:28 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Shuah Khan <skhan@...uxfoundation.org>, shuah@...nel.org,
        bamv2005@...il.com, khilman@...libre.com
Cc:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: add build/cross-build dependency check script

Hi,

On 4/14/20 2:22 PM, Shuah Khan wrote:
> -CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ $(MOUNT_CFLAGS)
> -LDLIBS += $(MOUNT_LDLIBS)
> +CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ $(VAR_CFLAGS)
> +LDLIBS += $(VAR_LDLIBS)

(1) Can that series of ../../../.. be replaced by $(objtree)?
If so, that would be much cleaner IMO.

(2) I can't find anything that checks that ../../../../usr/include exists
(or has been installed via 'make headers_install').  Or anything that
requires that CONFIG_HEADERS_INSTALL be set/enabled.  Well, other than
a Makefile error, but that's not a nice way to find out.

Preferably we would have some Kconfig check/enforcement or at least some
documentation.

Thoughts?

thanks.
-- 
~Randy