linux-kernel - Re: [PATCH] sched: make p->prio independent of p->mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200423204122.4c19b835@gandalf.local.home>
Date:   Thu, 23 Apr 2020 20:41:22 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Mike Galbraith <efault@....de>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] sched: make p->prio independent of p->mm

On Fri, 24 Apr 2020 08:30:28 +0800
Hillf Danton <hdanton@...a.com> wrote:

> > I believe Peter meant axing the double check, not the check together.
> > 
> > That is, instead of:
> > 
> > 	if (p->flags & PF_KTHREAD) {
> > 		if (attr->sched_priority > MAX_RT_PRIO - 1)
> > 			return -EINVAL;
> > 	} else {
> > 		if (attr->sched_priority > MAX_USER_RT_PRIO - 1)
> > 			return -EINVAL;
> > 	}
> > 
> > Just have:
> > 
> > 	if (attr->sched_priority > MAX_RT_PRIO -1)
> > 		return -EINVAL;
> >   
> Got it, thank you :) Spin in couple of days.

I still think getting rid of MAX_USER_RT_PRIO would be good too.

-- Steve