linux-kernel - Re: [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Apr 2020 14:30:08 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Rob Herring <robherring2@...il.com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by
 default

On Wed, Apr 22, 2020 at 02:29:57PM -0500, Rob Herring wrote:
> On Tue, Apr 14, 2020 at 07:12:41PM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > Drivers should not be selected by default because that bloats the kernel
> > for people who don't need them.
> > 
> > Remove the "default y" for CONFIG_PCI_DRA7XX_HOST.
> > 
> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > Cc: Kishon Vijay Abraham I <kishon@...com>
> > Cc: linux-omap@...r.kernel.org
> > ---
> >  drivers/pci/controller/dwc/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 03dcaf65d159..ea335ee7ca8e 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST
> >  	depends on OF && HAS_IOMEM && TI_PIPE3
> >  	select PCIE_DW_HOST
> >  	select PCI_DRA7XX
> > -	default y
> 
> Perhaps 'default y if SOC_DRA7XX'?

Good idea, I did that.