linux-kernel - Re: [PATCH] soundwire: intel: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200424195600.GA45659@ubuntu-s3-xlarge-x86>
Date:   Fri, 24 Apr 2020 12:56:00 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH] soundwire: intel: Remove unused function

On Wed, Apr 22, 2020 at 08:08:15PM +0100, Sudip Mukherjee wrote:
> The function sdw_intel_init() is not used anywhere, remove it for now.
> 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> ---
>  drivers/soundwire/intel_init.c | 23 -----------------------
>  1 file changed, 23 deletions(-)
> 
> diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
> index ad7053463889..2f37dad06321 100644
> --- a/drivers/soundwire/intel_init.c
> +++ b/drivers/soundwire/intel_init.c
> @@ -183,29 +183,6 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
>  }
>  
>  /**
> - * sdw_intel_init() - SoundWire Intel init routine
> - * @parent_handle: ACPI parent handle
> - * @res: resource data
> - *
> - * This scans the namespace and creates SoundWire link controller devices
> - * based on the info queried.
> - */
> -static void *sdw_intel_init(acpi_handle *parent_handle,
> -			    struct sdw_intel_res *res)
> -{
> -	acpi_status status;
> -
> -	status = acpi_walk_namespace(ACPI_TYPE_DEVICE,
> -				     parent_handle, 1,
> -				     sdw_intel_acpi_cb,
> -				     NULL, res, NULL);
> -	if (ACPI_FAILURE(status))
> -		return NULL;
> -
> -	return sdw_intel_add_controller(res);
> -}
> -
> -/**
>   * sdw_intel_exit() - SoundWire Intel exit
>   * @arg: callback context
>   *
> -- 
> 2.11.0
> 

This patch will cause two more warnings.

$ make -j$(nproc) -s O=out allyesconfig drivers/soundwire/intel_init.o
../drivers/soundwire/intel_init.c:152:20: warning: ‘sdw_intel_acpi_cb’
defined but not used [-Wunused-function]
 static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
                    ^~~~~~~~~~~~~~~~~
../drivers/soundwire/intel_init.c:51:2: warning:
‘sdw_intel_add_controller’ defined but not used [-Wunused-function]
 *sdw_intel_add_controller(struct sdw_intel_res *res)
  ^~~~~~~~~~~~~~~~~~~~~~~~

Removing these two functions seems to be enough. link_mask should also
be removed at that point.

Cheers,
Nathan