linux-kernel - Re: selinux_netlink_send changes program behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhQs6eJpX4oMrhBiDap-HhEsBBgmYWEou=ZH60YiA__T7w@mail.gmail.com>
Date:   Fri, 24 Apr 2020 17:51:42 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Dmitry Vyukov <dvyukov@...gle.com>
Cc:     Stephen Smalley <stephen.smalley.work@...il.com>,
        Eric Paris <eparis@...isplace.org>, selinux@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        syzkaller <syzkaller@...glegroups.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: selinux_netlink_send changes program behavior

On Fri, Apr 24, 2020 at 4:27 AM Dmitry Vyukov <dvyukov@...gle.com> wrote:
> Hi SELinux maintainers,
>
> We've hit a case where a developer wasn't able to reproduce a kernel
> bug, it turned out to be a difference in behavior between SELinux and
> non-SELinux kernels.
> Condensed version: a program does sendmmsg on netlink socket with 2
> mmsghdr's, first is completely empty/zeros, second contains some
> actual payload. Without SELinux the first mmsghdr is treated as no-op
> and the kernel processes the second one (triggers bug). However the
> SELinux hook does:
>
> static int selinux_netlink_send(struct sock *sk, struct sk_buff *skb)
> {
>     if (skb->len < NLMSG_HDRLEN) {
>         err = -EINVAL;
>         goto out;
>     }
>
> and fails processing on the first empty mmsghdr (does not happen
> without SELinux).
>
> Is this difference in behavior intentional/acceptable/should be fixed?

>From a practical perspective, SELinux is always going to need to do a
length check as it needs to peek into the netlink message header for
the message type so it can map that to the associated SELinux
permissions.  So in that sense, the behavior is intentional and
desired; however from a bug-for-bug compatibility perspective ... not
so much.

Ultimately, my it's-Friday-and-it's-been-a-long-week-ending-in-a-long-day
thought is that this was a buggy operation to begin with and the bug
was just caught in different parts of the kernel, depending on how it
was configured.  It may not be ideal, but I can think of worse things
(and arguably SELinux is doing the Right Thing).

-- 
paul moore
www.paul-moore.com