Date:   Fri, 24 Apr 2020 06:01:46 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Peter Xu <peterx@...hat.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "Christopherson, Sean J" <sean.j.christopherson@...el.com>,
        Christophe de Dinechin <dinechin@...hat.com>,
        "Zhao, Yan Y" <yan.y.zhao@...el.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        "Vitaly Kuznetsov" <vkuznets@...hat.com>,
        "Dr . David Alan Gilbert" <dgilbert@...hat.com>
Subject: RE: [PATCH v8 00/14] KVM: Dirty ring interface

> From: Peter Xu <peterx@...hat.com>
> Sent: Thursday, April 23, 2020 11:23 PM
> 
> On Thu, Apr 23, 2020 at 06:28:43AM +0000, Tian, Kevin wrote:
> > > From: Peter Xu <peterx@...hat.com>
> > > Sent: Thursday, April 23, 2020 2:52 AM
> > >
> > > Hi,
> > >
> > > TL;DR: I'm thinking whether we should record pure GPA/GFN instead of
> > > (slot_id,
> > > slot_offset) tuple for dirty pages in kvm dirty ring to unbind
> kvm_dirty_gfn
> > > with memslots.
> > >
> > > (A slightly longer version starts...)
> > >
> > > The problem is that binding dirty tracking operations to KVM memslots is
> a
> > > restriction that needs synchronization to memslot changes, which further
> > > needs
> > > synchronization across all the vcpus because they're the consumers of
> > > memslots.
> > > E.g., when we remove a memory slot, we need to flush all the dirty bits
> > > correctly before we do the removal of the memslot.  That's actually an
> > > known
> > > defect for QEMU/KVM [1] (I bet it could be a defect for many other
> > > hypervisors...) right now with current dirty logging.  Meanwhile, even if
> we
> > > fix it, that procedure is not scale at all, and error prone to dead locks.
> > >
> > > Here memory removal is really an (still corner-cased but relatively)
> important
> > > scenario to think about for dirty logging comparing to memory additions
> &
> > > movings.  Because memory addition will always have no initial dirty page,
> > > and
> > > we don't really move RAM a lot (or do we ever?!) for a general VM use
> case.
> > >
> > > Then I went a step back to think about why we need these dirty bit
> > > information
> > > after all if the memslot is going to be removed?
> > >
> > > There're two cases:
> > >
> > >   - When the memslot is going to be removed forever, then the dirty
> > > information
> > >     is indeed meaningless and can be dropped, and,
> > >
> > >   - When the memslot is going to be removed but quickly added back with
> > > changed
> > >     size, then we need to keep those dirty bits because it's just a commmon
> > > way
> > >     to e.g. punch an MMIO hole in an existing RAM region (here I'd confess
> I
> > >     feel like using "slot_id" to identify memslot is really unfriendly syscall
> > >     design for things like "hole punchings" in the RAM address space...
> > >     However such "punch hold" operation is really needed even for a
> common
> > >     guest for either system reboots or device hotplugs, etc.).
> >
> > why would device hotplug punch a hole in an existing RAM region?
> 
> I thought it could happen because I used to trace the KVM ioctls and see the
> memslot changes during driver loading.  But later when I tried to hotplug a

Is there more detail why driver loading may lead to memslot changes?

> device I do see that it won't...  The new MMIO regions are added only into
> 0xfe000000 for a virtio-net:
> 
>   00000000fe000000-00000000fe000fff (prio 0, i/o): virtio-pci-common
>   00000000fe001000-00000000fe001fff (prio 0, i/o): virtio-pci-isr
>   00000000fe002000-00000000fe002fff (prio 0, i/o): virtio-pci-device
>   00000000fe003000-00000000fe003fff (prio 0, i/o): virtio-pci-notify
>   00000000fe840000-00000000fe84002f (prio 0, i/o): msix-table
>   00000000fe840800-00000000fe840807 (prio 0, i/o): msix-pba
> 
> Does it mean that device plugging is guaranteed to not trigger RAM changes?

I'd think so. Otherwise from guest p.o.v any device hotplug implies doing
a memory hot-unplug first then it's a bad design.

> I
> am really curious about what cases we need to consider in which we need to
> keep
> the dirty bits for a memory removal, and if system reset is the only case, then
> it could be even easier (because we might be able to avoid the sync in
> memory
> removal but do that once in a sys reset hook)...

Possibly memory hot-unplug, as allowed by recent virtio-mem? 

btw VFIO faces a similar problem when unmapping a DMA range (e.g. when
vIOMMU is enabled) in dirty log phase. There could be some dirty bits which are
not retrieved when unmapping happens. VFIO chooses to return the dirty
bits in a buffer passed in the unmapping parameters. Can memslot interface
do similar thing by allowing the userspace to specify a buffer pointer to hold
whatever dirty pages recorded for the slot that is being removed?

> 
> >
> > >
> > > The real scenario we want to cover for dirty tracking is the 2nd one.
> > >
> > > If we can track dirty using raw GPA, the 2nd scenario is solved itself.
> > > Because we know we'll add those memslots back (though it might be with
> a
> > > different slot ID), then the GPA value will still make sense, which means
> we
> > > should be able to avoid any kind of synchronization for things like
> memory
> > > removals, as long as the userspace is aware of that.
> >
> > A curious question. What about the backing storage of the affected GPA
> > is changed after adding back? Is recorded dirty info for previous backing
> > storage still making sense for the newer one?
> 
> It's the case of a permanent removal, plus another addition iiuc.  Then the
> worst case is we get some extra dirty bits set on that new memory region,
> but
> IMHO that's benigh (we'll migrate some extra pages even they could be zero
> pages).

yes, reporting more than necessary dirty bits doesn't hurt. 

> 
> Thanks,
> 
> >
> > Thanks
> > Kevin
> >
> > >
> > > With that, when we fetch the dirty bits, we lookup the memslot
> dynamically,
> > > drop bits if the memslot does not exist on that address (e.g., permanent
> > > removals), and use whatever memslot is there for that guest physical
> > > address.
> > > Though we for sure still need to handle memory move, that the
> userspace
> > > needs
> > > to still take care of dirty bit flushing and sync for a memory move,
> however
> > > that's merely not happening so nothing to take care about either.
> > >
> > > Does this makes sense?  Comments greatly welcomed..
> > >
> > > Thanks,
> > >
> > > [1] https://lists.gnu.org/archive/html/qemu-devel/2020-
> 03/msg08361.html
> > >
> > > --
> > > Peter Xu
> >
> 
> --
> Peter Xu

Powered by blists - more mailing lists