linux-kernel - Re: [PATCH] EDAC: remove defined but not used 'bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Apr 2020 09:31:42 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rrichter@...vell.com, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] EDAC: remove defined but not used 'bridge_str'

On Wed, Apr 15, 2020 at 04:50:06PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
> 
> drivers/edac/amd8131_edac.c:47:21: warning: ‘bridge_str’ defined but not
> used [-Wunused-const-variable=]
>  static char * const bridge_str[] = {
>                      ^~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/edac/amd8131_edac.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c
> index 93c82bc17493..169353710982 100644
> --- a/drivers/edac/amd8131_edac.c
> +++ b/drivers/edac/amd8131_edac.c
> @@ -44,14 +44,6 @@ static void edac_pci_write_dword(struct pci_dev *dev, int reg, u32 val32)
>  			" PCI Access Write Error at 0x%x\n", reg);
>  }
>  
> -static char * const bridge_str[] = {
> -	[NORTH_A] = "NORTH A",
> -	[NORTH_B] = "NORTH B",
> -	[SOUTH_A] = "SOUTH A",
> -	[SOUTH_B] = "SOUTH B",
> -	[NO_BRIDGE] = "NO BRIDGE",
> -};
> -
>  /* Support up to two AMD8131 chipsets on a platform */
>  static struct amd8131_dev_info amd8131_devices[] = {
>  	{
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette