linux-kernel - Re: [PATCH] drm: amdgpu: Move static inline keyword to the front of declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d50f774-ebd0-e700-9713-209ccb8010f0@amd.com>
Date:   Fri, 24 Apr 2020 09:40:49 +0200
From:   Christian König <christian.koenig@....com>
To:     ChenTao <chentao107@...wei.com>, David1.Zhou@....com,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     Hawking.Zhang@....com, evan.quan@....com,
        andrey.grodzovsky@....com, Monk.Liu@....com, kent.russell@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: amdgpu: Move static inline keyword to the front of
 declarations

Am 24.04.20 um 05:13 schrieb ChenTao:
> Fix the following warning:
>
> Move the static inline keyword to the front of declarations
> amdgpu_device_wreg_no_kiq, and resolve the following
> compiler warnings that can be seen when building
> with warnings enabled (W=1):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
> ‘static’ is not at beginning of declaration
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
> ‘inline’ is not at beginning of declaration
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: ChenTao <chentao107@...wei.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index ad1c66763dc1..d53a5e3f464b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -341,7 +341,7 @@ void amdgpu_mm_wreg8(struct amdgpu_device *adev, uint32_t offset, uint8_t value)
>   		BUG();
>   }
>   
> -void static inline amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
> +static inline void amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
>   					     uint32_t v, uint32_t acc_flags)
>   {
>   	trace_amdgpu_device_wreg(adev->pdev->device, reg, v);