linux-kernel - RE: [RFC PATCH 0/4] iio: scan_mask rework to track enabled channels on per-channel basis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR03MB3350FBD3C1AE562371E5CF4799D00@CY4PR03MB3350.namprd03.prod.outlook.com>
Date:   Fri, 24 Apr 2020 07:51:02 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "jic23@...nel.org" <jic23@...nel.org>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
Subject: RE: [RFC PATCH 0/4] iio: scan_mask rework to track enabled channels
 on per-channel basis

> From: linux-iio-owner@...r.kernel.org <linux-iio-owner@...r.kernel.org>
> On Behalf Of Alexandru Ardelean
> Sent: Freitag, 24. April 2020 07:18
> To: linux-iio@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: jic23@...nel.org; lars@...afoo.de; Ardelean, Alexandru
> <alexandru.Ardelean@...log.com>
> Subject: [RFC PATCH 0/4] iio: scan_mask rework to track enabled channels on
> per-channel basis
> 
> 
> From my side, I'll admit that the specific use-cases for these patches
> are a bit outside of my scope of understanding.
> I did my best to re-apply them on a newer tree, and dig-up the
> information from the ADI tree [where they've been living for a while
> now].
> 
> Also, I don't have any idea if there was a prior discussion about this.
> I could not find anything on a quick search.
> 
> I'm hoping that the author would have some input on them/
> 
> Hence the RFC.
> 

Yeah, I remember I stumbled against this when looking to some of our drivers where we have (IIRC) a 16
channel ADC where 1 channel occupies 1 bit. I just gave a quick look on this and it looks good to me
(naturally it needs a deeper look :D). I just have one remark/question inline in patch 4.

- Nuno Sá