linux-kernel - Re: [RFC PATCH 1/3] dt-bindings: gpio-rcar: Add optional use-alternative-interrupt property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXvrBHuBpVbJ=fUcRsQ9qk4Q3Lr13DeJjiHanN3f8K+1g@mail.gmail.com>
Date:   Fri, 24 Apr 2020 10:06:59 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Eugeniu Rosca <erosca@...adit-jv.com>
Cc:     Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Chris Paterson <chris.paterson2@...esas.com>,
        Yusuke Ashiduka <ashiduka@...itsu.com>,
        Torii Kenichi <torii.ken1@...fujitsu.com>,
        Fukui Yohhei <yohhei.fukui@...so-ten.com>,
        Yasushi Asano <yasano@...adit-jv.com>,
        Yuichi Kusakabe <yuichi.kusakabe@...so-ten.com>,
        Andrew Gabbasov <andrew_gabbasov@...tor.com>,
        Jiada Wang <jiada_wang@...tor.com>,
        Eugeniu Rosca <rosca.eugeniu@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [RFC PATCH 1/3] dt-bindings: gpio-rcar: Add optional
 use-alternative-interrupt property

Hi Eugeniu,

CC devicetree

On Wed, Apr 22, 2020 at 12:11 PM Eugeniu Rosca <erosca@...adit-jv.com> wrote:
> From: Torii Kenichi <torii.ken1@...fujitsu.com>
>
> When setting this property, you must set alternate interrupt number in
> the 'interrupts' property.
>
> Signed-off-by: Torii Kenichi <torii.ken1@...fujitsu.com>
> [erosca: tidy up the descriptions/comments]
> Signed-off-by: Eugeniu Rosca <erosca@...adit-jv.com>

Thanks for your/forwarding this patch!

> --- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
> +++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
> @@ -50,6 +50,9 @@ Optional properties:
>    - clocks: Must contain a reference to the functional clock.  The property is
>      mandatory if the hardware implements a controllable functional clock for
>      the GPIO instance.
> +  - use-alternative-interrupt: Use 'alternative' GPIO interrupt instead

renesas,use-alternative-interrupt?
(unless you can convince Rob this becomes a generic property).

> +    of 'normal' GPIO interrupt. When you specify this property, you must
> +    also change the 'interrupts' DT property.

In light of "DT describes the hardware", I think you should instead list
both interrupts in DT.  I.e. first/single interrupt is the normal one,
second optional interrupt is the alternative one.

On R-Car Gen2, the oldest SoC family with this feature I could find,
they are called "ext_int" resp. "ext_alt_int", so introducing the
optional "clock-names" property would be a good idea, too.

>    - gpio-reserved-ranges: See gpio.txt.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds