linux-kernel - Re: [PATCH] sysrq: export sysrq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200424090436.GA358113@kroah.com>
Date:   Fri, 24 Apr 2020 11:04:36 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Paolo Pisati <paolo.pisati@...onical.com>
Cc:     Jiri Slaby <jslaby@...e.com>, Dmitry Safonov <dima@...sta.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysrq: export sysrq_mask symbol

On Fri, Apr 24, 2020 at 10:53:46AM +0200, Paolo Pisati wrote:
> Commit "68af431 serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE" breaks
> the build if CONFIG_SERIAL_CORE=m:
> 
> ...
> ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1331: modules] Error 2
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@...onical.com>
> ---
>  drivers/tty/sysrq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 5e0d0813da55..cf49010335fd 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -74,6 +74,7 @@ int sysrq_mask(void)
>  		return 1;
>  	return sysrq_enabled;
>  }
> +EXPORT_SYMBOL(sysrq_mask);
>  
>  /*
>   * A value of 1 means 'all', other nonzero values are an op mask:

Already in my tty tree, will go to Linus tomorrow, thanks!

greg k-h