linux-kernel - Re: [PATCH] dt-bindings: spi: Convert UniPhier SPI controller to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1243a377-cb88-3fa5-fcf9-75da200d9a9c@socionext.com>
Date:   Fri, 24 Apr 2020 18:12:24 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: spi: Convert UniPhier SPI controller to
 json-schema

On 2020/04/17 10:30, Kunihiko Hayashi wrote:
> Convert UniPhier SPI controller binding to DT schema format.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> ---
>   .../bindings/spi/socionext,uniphier-spi.yaml       | 55 ++++++++++++++++++++++
>   .../devicetree/bindings/spi/spi-uniphier.txt       | 28 -----------
>   2 files changed, 55 insertions(+), 28 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml
>   delete mode 100644 Documentation/devicetree/bindings/spi/spi-uniphier.txt
> 
> diff --git a/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml b/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml
> new file mode 100644
> index 0000000..bab8bcc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/socionext,uniphier-spi.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/socionext,uniphier-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier SPI controller
> +
> +description: |
> +  UniPhier SoCs have SCSSI which supports SPI single channel.
> +
> +maintainers:
> +  - Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> +  - Keiji Hayashibara <hayashibara.keiji@...ionext.com>
> +
> +allOf:
> +  - $ref: spi-controller.yaml#
> +
> +properties:
> +  "#address-cells": true
> +  "#size-cells": true
> +
> +  compatible:
> +    const: socionext,uniphier-scssi
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - resets

According to spi-controller.yaml, the "#address-cells" is required.
And the "#size-cells" is also required because it specifies "const: 0".
I'll add them in v2.

Thank you,

---
Best Regards
Kunihiko Hayashi