linux-kernel - Re: [PATCH 1/1] pinctrl: add IRQF_EARLY_RESUME flags with gpio irq for elan touchpad.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Apr 2020 12:50:30 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     caizhaopeng@...ontech.com
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andy@...nel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Zhangyueqian <zhangyueqian@...ontech.com>,
        Zhangshuang <zhangshuang@...ontech.com>,
        Hualet Wang <wangyaohua@...ontech.com>,
        Zhanglei <zhanglei@...ontech.com>
Subject: Re: [PATCH 1/1] pinctrl: add IRQF_EARLY_RESUME flags with gpio irq
 for elan touchpad.

On Fri, Apr 24, 2020 at 12:16 PM <caizhaopeng@...ontech.com> wrote:
>
> From: Caicai <caizhaopeng@...ontech.com>
>
> I had tested two Notebook machines, the Intel i5(or amd ryzen)
> with elan touchpad, and there's a probability that the touchpad
> won't work after going to the S3/S4 to wake up, that it would
> appear no more than 15 times. I found that there's no interrupt
> to check for /proc/interrupt. It was found that the gpio
> interrupt of i2c was also not on top. By adding the gpio
> interrupt flags with IRQF_EARLY_RESUME, now the touchpad tested
> 200 + times works well.

Thanks for the contribution!

You need
a) to split this to patch per driver (I can't take or speak for AMD
code, I'm not a maintainer and don't have hardware)
b) explain what this flag actually means and does

On top of that we need to test this widely to avoid regressions.

-- 
With Best Regards,
Andy Shevchenko