linux-kernel - Re: [PATCHv2] i2c: slave-eeprom: Make it possible to pre-load eeprom data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200424111337.GC1959@kunai>
Date:   Fri, 24 Apr 2020 13:13:37 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Björn Ardö <bjorn.ardo@...s.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        patrick@...cx.xyz, kernel@...s.com
Subject: Re: [PATCHv2] i2c: slave-eeprom: Make it possible to pre-load eeprom
 data


On second look, two questions:

> +	if (!error) {
> +		int ret = request_firmware_into_buf(&fw, eeprom_data, &client->dev,
> +						    eeprom->buffer, size);
> +		if (ret)
> +			return ret;

Aren't we leaking 'fw' here?

Also, do we need 'error' and 'ret'? Can't we reuse one of them?

> +		release_firmware(fw);


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)