linux-kernel - RE: [PATCH V2] dt-bindings: firmware: imx: Move system control into dt-binding headfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR04MB49665B1D0657ADCCA3B10FF780D00@AM6PR04MB4966.eurprd04.prod.outlook.com>
Date:   Fri, 24 Apr 2020 01:48:31 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Anson Huang <anson.huang@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "amit.kucheria@...durent.com" <amit.kucheria@...durent.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Leonard Crestez <leonard.crestez@....com>,
        "linux@...pel-privat.de" <linux@...pel-privat.de>,
        Peng Fan <peng.fan@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2] dt-bindings: firmware: imx: Move system control into
 dt-binding headfile

> From: Anson Huang <anson.huang@....com>
> Sent: Friday, April 24, 2020 6:29 AM
> 
> > Subject: RE: [PATCH V2] dt-bindings: firmware: imx: Move system
> > control into dt-binding headfile
> >
> > > From: Anson Huang <Anson.Huang@....com>
> > > Sent: Thursday, April 23, 2020 11:36 PM
> > >
> > > i.MX8 SoCs DTS file needs system control macro definitions, so move
> > > them into dt-binding headfile, then
> > > include/linux/firmware/imx/types.h
> > > can be removed and those drivers using it should be changed accordingly.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@....com>
> >
> > You seems ignored my comments in V1.
> > Usually we'd better to keep original author when sending patches if no
> > fundamental changes.
> 
> Here is the details, the aim of this patch is to get rid of below patch in internal
> tree, I did NOT check the details of internal tree and did the patch manually and
> did NOT check how many patches I need in internal tree in order to make the
> build passed. After checking it, looks like there are 3 patches, 2 are from you,
> and 1 from Jacky. Since these patches need to be squashed into 1 patch, also fix
> minor comment in code and improve the comment, so, should I put you as
> author or Jacky as author??
> 

As there're no code changes, for such a case, we usually keep origin author
and add Jacky signoff and you signoff.

Regards
Aisheng

> commit cb6603999367aeae57004638a4b8e43ee618dbec
> Author: Jacky Bai <ping.bai@....com>
> Date:   Mon Mar 9 14:41:44 2020 +0800
> 
>     thermal: imx_sc_thermal: fix the build break caused non existent types.h
> 
>     The types.h has been move to the dt-bindings/, so correct the included
>     header file to fix the build break.