linux-kernel - RE: [PATCH 4/5] scsi: ufs: tc-dwc-pci: Allow for MSI interrupt type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN8PR12MB326683F270F887D309490462D3D00@BN8PR12MB3266.namprd12.prod.outlook.com>
Date:   Fri, 24 Apr 2020 12:02:12 +0000
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     "Winkler, Tomas" <tomas.winkler@...el.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     Joao Pinto <Joao.Pinto@...opsys.com>,
        Joao Lima <Joao.Lima@...opsys.com>,
        "Alim Akhtar" <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4/5] scsi: ufs: tc-dwc-pci: Allow for MSI interrupt type

From: Winkler, Tomas <tomas.winkler@...el.com>
Date: Apr/24/2020, 12:55:57 (UTC+00:00)

> > 
> > Newer Test Chips boards have MSI support. It does no harm to try to request it
> > as the function will fallback to legacy interrupts if MSI is not supported.
> > 
> > Signed-off-by: Jose Abreu <Jose.Abreu@...opsys.com>
> > 
> > ---
> > Cc: Joao Lima <Joao.Lima@...opsys.com>
> > Cc: Jose Abreu <Jose.Abreu@...opsys.com>
> > Cc: Alim Akhtar <alim.akhtar@...sung.com>
> > Cc: Avri Altman <avri.altman@....com>
> > Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com>
> > Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> > Cc: linux-scsi@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > ---
> >  drivers/scsi/ufs/tc-dwc-pci.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/scsi/ufs/tc-dwc-pci.c b/drivers/scsi/ufs/tc-dwc-pci.c index
> > 74a2d80d32bd..e0a880cbbe68 100644
> > --- a/drivers/scsi/ufs/tc-dwc-pci.c
> > +++ b/drivers/scsi/ufs/tc-dwc-pci.c
> > @@ -136,9 +136,15 @@ tc_dwc_pci_probe(struct pci_dev *pdev, const struct
> > pci_device_id *id)
> >  		return -ENOENT;
> >  	}
> > 
> > +	err = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> PCI_IRQ_LEGACY | PCI_IRQ_MSI , is enough  you don't have MSIX

Makes sense :)

> > +	if (err < 0) {
> > +		dev_err(&pdev->dev, "Allocation failed\n");
> > +		return err;
> > +	}
> > +
> Where do you call pci_free_irq_vectors() ? 

Right ... Will be fixed in v2. Thanks!

---
Thanks,
Jose Miguel Abreu