linux-kernel - Re: [PATCH] ARM: dts: imx53: ppd: alarm LEDs use kernel LED interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200424124423.jo25ai5oifvalgpr@earth.universe>
Date:   Fri, 24 Apr 2020 14:44:23 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Ian Ray <ian.ray@...com>, Samu Nuutamo <samu.nuutamo@...cit.fi>
Subject: Re: [PATCH] ARM: dts: imx53: ppd: alarm LEDs use kernel LED interface

Hi,

On Fri, Apr 24, 2020 at 11:32:26AM +0200, Pavel Machek wrote:
> On Thu 2020-04-16 16:51:23, Sebastian Reichel wrote:
> > From: Ian Ray <ian.ray@...com>
> > 
> > Use kernel LED interface for the alarm LEDs.
> 
> Could we get these changes cced to LED maintainers?

Sorry, you are not turning up via get_maintainer.pl and usually
subsystem maintainers are not CC'd for every DT device instance.
E.g. I do not want to be always CC'd for DT board file containing
a battery/charger. I'm quite surprised you want to be CC'd for
them, just looking at ARM DT files there are over 1000 instances
of leds.

> > +		alarm1 {
> > +			label = "alarm:red";
> > +			gpios = <&gpio7 3 GPIO_ACTIVE_HIGH>;
> > +		};
> 
> So... What is function of these leds, and can we get naming more
> consistent with rest of the kernel?

The device is a medical patient monitor and these are alarm LEDs
informing about critical device or patient status. They are
referenced by their color (those are discrete LEDs, not a
multi-color one) basically everywhere. The only exception is
"silenced", which means that audible alarm is surpressed. I
don't think we have something comparable for any of those LEDs
in the mainline tree.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)