lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Apr 2020 15:44:48 +0200 From: Jose Abreu <Jose.Abreu@...opsys.com> To: linux-scsi@...r.kernel.org Cc: Joao Pinto <Joao.Pinto@...opsys.com>, Jose Abreu <Jose.Abreu@...opsys.com>, "Winkler, Tomas" <tomas.winkler@...el.com>, Joao Lima <Joao.Lima@...opsys.com>, Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, linux-kernel@...r.kernel.org Subject: [PATCH v2 4/5] scsi: ufs: tc-dwc-pci: Allow for MSI interrupt type Newer Test Chips boards have MSI support. It does no harm to try to request it as the function will fallback to legacy interrupts if MSI is not supported. Signed-off-by: Jose Abreu <Jose.Abreu@...opsys.com> --- Changes from v1: - Do not try to request MSIX vectors (Tomas) - Add missing call to pci_free_irq_vectors() (Tomas) Cc: "Winkler, Tomas" <tomas.winkler@...el.com> Cc: Joao Lima <Joao.Lima@...opsys.com> Cc: Jose Abreu <Jose.Abreu@...opsys.com> Cc: Alim Akhtar <alim.akhtar@...sung.com> Cc: Avri Altman <avri.altman@....com> Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@...cle.com> Cc: linux-scsi@...r.kernel.org Cc: linux-kernel@...r.kernel.org --- drivers/scsi/ufs/tc-dwc-pci.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/tc-dwc-pci.c b/drivers/scsi/ufs/tc-dwc-pci.c index 74a2d80d32bd..78dc6c484e84 100644 --- a/drivers/scsi/ufs/tc-dwc-pci.c +++ b/drivers/scsi/ufs/tc-dwc-pci.c @@ -88,6 +88,7 @@ static void tc_dwc_pci_remove(struct pci_dev *pdev) pm_runtime_forbid(&pdev->dev); pm_runtime_get_noresume(&pdev->dev); ufshcd_remove(hba); + pci_free_irq_vectors(pdev); } /** @@ -136,11 +137,18 @@ tc_dwc_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) return -ENOENT; } + err = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY | PCI_IRQ_MSI); + if (err < 0) { + dev_err(&pdev->dev, "Allocation failed\n"); + return err; + } + hba->vops = &data->ops; - err = ufshcd_init(hba, mmio_base, pdev->irq); + err = ufshcd_init(hba, mmio_base, pci_irq_vector(pdev, 0)); if (err) { dev_err(&pdev->dev, "Initialization failed\n"); + pci_free_irq_vectors(pdev); return err; } -- 2.7.4
Powered by blists - more mailing lists