linux-kernel - Re: [PATCH 2/3] usb/xhci-plat: Set PM runtime as active on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.2004241102400.2596-100000@netrider.rowland.org>
Date:   Fri, 24 Apr 2020 11:03:47 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Qais Yousef <qais.yousef@....com>
cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Tony Prisk <linux@...sktech.co.nz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Oliver Neukum <oneukum@...e.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] usb/xhci-plat: Set PM runtime as active on resume

On Fri, 24 Apr 2020, Qais Yousef wrote:

> Follow suit of ohci-platform.c and perform pm_runtime_set_active() on
> resume.
> 
> ohci-platform.c had a warning reported due to the missing
> pm_runtime_set_active() [1].
> 
> [1] https://lore.kernel.org/lkml/20200323143857.db5zphxhq4hz3hmd@e107158-lin.cambridge.arm.com/
> 
> Signed-off-by: Qais Yousef <qais.yousef@....com>
> CC: Tony Prisk <linux@...sktech.co.nz>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Mathias Nyman <mathias.nyman@...el.com>
> CC: Oliver Neukum <oneukum@...e.de>
> CC: linux-arm-kernel@...ts.infradead.org
> CC: linux-usb@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> ---
> 
> xhci_resume() here could fail, I wasn't sure if we need to call
> pm_runtime_set_active() unconditionally. I assumed not.
> 
> There was another function xhci_plat_resume(), I think we just care about the
> PM runtime resume callback only.
> 
> Please have a closer look.

No, it's the other way around.  The function you want to change is the 
one used for system resume, not runtime resume.

Alan Stern