linux-kernel - Re: [PATCH] clocksource: timer-ti-dm: Drop bogus omap_dm_timer_of_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7debff4f-8f64-ee7c-2fdd-879649e35eb0@ti.com>
Date:   Sat, 25 Apr 2020 14:44:03 +0530
From:   Lokesh Vutla <lokeshvutla@...com>
To:     Suman Anna <s-anna@...com>, Tony Lindgren <tony@...mide.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
CC:     <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Tero Kristo <t-kristo@...com>,
        Neil Armstrong <narmstrong@...libre.com>,
        "H . Nikolaus Schaller" <hns@...delico.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Keerthy <j-keerthy@...com>,
        Ladislav Michl <ladis@...ux-mips.org>,
        Pavel Machek <pavel@....cz>, Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH] clocksource: timer-ti-dm: Drop bogus
 omap_dm_timer_of_set_source()

Hi Tony, Suman,

On 13/02/20 11:05 AM, Suman Anna wrote:
> The function omap_dm_timer_of_set_source() was originally added in
> commit 31a7448f4fa8a ("ARM: OMAP: dmtimer: Add clock source from DT"),
> and is designed to set a clock source from DT using the clocks property
> of a timer node. This design choice is okay for clk provider nodes but
> otherwise is a bad design as typically the clocks property is used to
> specify the functional clocks for a device, and not its parents.
> 
> The timer nodes now all define a timer functional clock after the
> conversion to ti-sysc and the new clkctrl layout, and this results
> in an attempt to set the same functional clock as its parent when a
> consumer driver attempts to acquire any of these timers in the
> omap_dm_timer_prepare() function. This was masked and worked around
> in commit 983a5a43ec25 ("clocksource: timer-ti-dm: Fix pwm dmtimer
> usage of fck reparenting"). Fix all of this by simply dropping the
> entire function.
> 
> Any DT configuration of clock sources should be achieved using
> assigned-clocks and assigned-clock-parents properties provided
> by the Common Clock Framework.
> 
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Tero Kristo <t-kristo@...com>
> Cc: Neil Armstrong <narmstrong@...libre.com>
> Cc: H. Nikolaus Schaller <hns@...delico.com>
> Cc: Bartosz Golaszewski <bgolaszewski@...libre.com>
> Cc: Keerthy <j-keerthy@...com>
> Cc: Ladislav Michl <ladis@...ux-mips.org>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Sebastian Reichel <sre@...nel.org>
> Signed-off-by: Suman Anna <s-anna@...com>
> ---
> Hi Tony,
> 
> Do you have the history of why the 32 KHz source is set as parent during
> prepare? One of the current side-affects of this patch is that now instead
> of bailing out, the 32 KHz source is set, and consumers will still need
> to select their appropriate parent. Dropping that call should actually
> allow us to select the parents in the consumer nodes in dts files using
> the assigned-clocks and assigned-clock-parents properties. I prefer to
> drop it if you do not foresee any issues. For now, I do not anticipate
> any issues with omap-pwm-dmtimer with this patch.
> 

Sorry to bring up an old thread. But ping on this question by Suman. prepare()
is over writing any parent set by DT to 32KHz. Is it possible to know why
prepare is doing it? If there is no proper reason can we drop this setting all
together?

Thanks and regards,
Lokesh