linux-kernel - Re: [PATCH net-next v2 2/9] dt-bindings: net: add backplane dt bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200425102711.GW25745@shell.armlinux.org.uk>
Date:   Sat, 25 Apr 2020 11:27:11 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Florinel Iordache <florinel.iordache@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        f.fainelli@...il.com, hkallweit1@...il.com,
        devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
        robh+dt@...nel.org, mark.rutland@....com, kuba@...nel.org,
        corbet@....net, shawnguo@...nel.org, leoyang.li@....com,
        madalin.bucur@....nxp.com, ioana.ciornei@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/9] dt-bindings: net: add backplane dt
 bindings

On Fri, Apr 24, 2020 at 03:46:24PM +0300, Florinel Iordache wrote:
> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> index ac471b6..541cee5 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> @@ -93,8 +93,9 @@ properties:
>        - rxaui
>        - xaui
>  
> -      # 10GBASE-KR, XFI, SFI
> +      # 10GBASE-KR, 40GBASE-KR4, XFI, SFI
>        - 10gbase-kr
> +      - 40gbase-kr4
>        - usxgmii

This makes a nonsense of the comment (and is actually something I failed
to update with the 10GBASE-R change).

The comment "10GBASE-KR, XFI, SFI" was there to describe _only_ the
following option, so your addition should look like:

	# 10GBASE-KR, XFI, SFI
	- 10gbase-kr
	# 40GBASE-KR4
	- 40gbase-kr4

Whereas there should also be a fix for the lack of 10GBASE-R, so it
should finally look like this:

	# 10GBASE-R, XFI, SFI
	- 10gbase-r
	# 10GBASE-KR (10GBASE-R with backplane negotiation)
	- 10gbase-kr
	# 40GBASE-KR4 (...)
	- 40gbase-kr4

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up