linux-kernel - Re: [PATCH v3] staging: wfx: cleanup long lines in data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 25 Apr 2020 12:54:32 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Suraj Upadhyay <usuraj35@...il.com>
Cc:     jerome.pouiller@...abs.com, dan.carpenter@...cle.com,
        devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: wfx: cleanup long lines in data_tx.c

On Fri, Apr 24, 2020 at 07:18:34PM +0530, Suraj Upadhyay wrote:
> Break lines with length over 80 characters to conform
> to the linux coding style and refactor wherever necessary.
> 
> Signed-off-by: Suraj Upadhyay <usuraj35@...il.com>
> ---
> 
> Changes in v3:
> 	- Changed the temporary variable name for the memzcmp statement
> 	  to is_used. (as suggested).
> 	- Added a temporary ieee80211_supported_band variable to address
> 	  the problem in wfx_get_hw_rate() more efficiently. (not
> 	  suggested, but still).
> 
> Changes in v2:
>         - Introduced a temporary variable for the memzcmp statement.
>         - Addressed the checkpatch problem with wfx_get_hw_rate().
>         - Restored the function definition of wfx_tx_get_tx_parms
>           as suggested by the reviewer.
>         - Added suggested changes for req->packet_id statement.
> 
>  drivers/staging/wfx/data_tx.c | 40 +++++++++++++++++++++++------------
>  1 file changed, 26 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 9c1a91207dd8..717155975345 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -20,6 +20,8 @@
>  static int wfx_get_hw_rate(struct wfx_dev *wdev,
>  			   const struct ieee80211_tx_rate *rate)
>  {
> +
> +	struct ieee80211_supported_band *band;
>  	if (rate->idx < 0)

checkpatch did not complain about this change?

It should have...

Please fix that up.

thanks,

greg k-h