linux-kernel - Re: [PATCH v4 3/4] iio: vcnl4000: Add sampling frequency support for VCNL4010/20.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VebfouNqOJjiKY0zAdxG5d+_JmpO5aVYR_EqcjsmBeXyg@mail.gmail.com>
Date:   Sat, 25 Apr 2020 20:14:51 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Mathieu Othacehe <m.othacehe@...il.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/4] iio: vcnl4000: Add sampling frequency support for VCNL4010/20.

On Sat, Apr 25, 2020 at 6:52 PM Jonathan Cameron <jic23@...nel.org> wrote:
> On Tue, 21 Apr 2020 15:22:11 +0300
> Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> > On Tue, Apr 21, 2020 at 10:56 AM Mathieu Othacehe <m.othacehe@...il.com> wrote:

...

> > > +static const int vcnl4010_prox_sampling_frequency[][2] = {
> > > +       {1, 950000},
> > > +       {3, 906250},
> > > +       {7, 812500},
> > > +       {16, 625000},
> > > +       {31, 250000},
> > > +       {62, 500000},
> > > +       {125, 0},
> >
> > > +       {250, 0}
> >
> > Leave comma here, potentially helpful if it will be extended.
>
> Hi Andy,
>
> Doesn't particularly matter either way, but given this is a list of the values
> supported by the device, very unlikely it will be extended.
>
> Games like trying to share the first part of a longer array between
> multiple device types might occur, but those are usually really ugly.

Good point. Though I would limit amount of entries by explicitly
writing down the array size.

> > > +};

-- 
With Best Regards,
Andy Shevchenko