linux-kernel - Re: linux-next: build failure after merge of the sound-asoc tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a72zgn2m.fsf@mpe.ellerman.id.au>
Date:   Sun, 26 Apr 2020 09:30:57 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Mark Brown <broonie@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        YueHaibing <yuehaibing@...wei.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Subject: Re: linux-next: build failure after merge of the sound-asoc tree

Mark Brown <broonie@...nel.org> writes:
> On Thu, Apr 23, 2020 at 11:04:00PM +1000, Stephen Rothwell wrote:
>> On Thu, 23 Apr 2020 12:30:41 +0100 Mark Brown <broonie@...nel.org> wrote:
>
>> > It looks like this is triggered by PowerPC not including
>> > drivers/firmware - there are missing dependencies but it works for other
>> > all*configs since the dependencies all get built in those.  It would be
>> > helpful if PowerPC were fixed to include the firmware directory to
>> > improve coverage.
>
>> $ git grep drivers/firmware 'arch/*/*Kconfig*'
>> arch/arm/Kconfig:source "drivers/firmware/Kconfig"
>> arch/arm64/Kconfig:source "drivers/firmware/Kconfig"
>> arch/ia64/Kconfig:source "drivers/firmware/Kconfig"
>> arch/mips/Kconfig:source "drivers/firmware/Kconfig"
>> arch/x86/Kconfig:source "drivers/firmware/Kconfig"
>
>> so, sure, it works for some architectures.  We would need someone to do
>> the work to make sure that adding drivers/firmware to all the others
>> does not break other stuff.  Until then, please add the needed
>> dependencies.
>
> I am doing that but that still doesn't mean that the architectures
> shouldn't be updated - to me this is like the architectures that don't
> implement standard APIs, we should fix the issues they bring up but it'd
> be a lot less noisy to sidestep the issue.

I don't think it's really like architectures that don't implement
standard APIs.

It's more like architectures not building code they don't need, AFAICS
none of the drivers under there can ever be used on powerpc.

Similarly we don't build drivers/acpi.

But if there's a good reason that we should be building it then I'm
happy to take a patch adding it.

cheers