linux-kernel - RE: [PATCH -next] misc: xilinx_sdfec: Use memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR02MB4140944FA4196DB021A7E276CBAE0@DM6PR02MB4140.namprd02.prod.outlook.com>
Date:   Sun, 26 Apr 2020 16:01:22 +0000
From:   Dragan Cvetic <draganc@...inx.com>
To:     Zou Wei <zou_wei@...wei.com>, Derek Kiernan <dkiernan@...inx.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Michal Simek <michals@...inx.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] misc: xilinx_sdfec: Use memdup_user() as a cleanup

Hi Zou,

Thanks for fixing the warning.

> -----Original Message-----
> From: Zou Wei <zou_wei@...wei.com>
> Sent: Wednesday 22 April 2020 03:59
> To: Derek Kiernan <dkiernan@...inx.com>; Dragan Cvetic <draganc@...inx.com>; arnd@...db.de; gregkh@...uxfoundation.org;
> Michal Simek <michals@...inx.com>
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Zou Wei <zou_wei@...wei.com>
> Subject: [PATCH -next] misc: xilinx_sdfec: Use memdup_user() as a cleanup
> 
> Fix coccicheck warning which recommends to use memdup_user().
> 
> This patch fixes the following coccicheck warnings:
> 
> drivers/misc/xilinx_sdfec.c:652:8-15: WARNING opportunity for memdup_user
> 
> Fixes: 20ec628e8007 ("misc: xilinx_sdfec: Add ability to configure LDPC")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/misc/xilinx_sdfec.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 71bbaa5..7a75894 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg)
>  	struct xsdfec_ldpc_params *ldpc;
>  	int ret, n;
> 
> -	ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL);
> -	if (!ldpc)
> -		return -ENOMEM;
> -
> -	if (copy_from_user(ldpc, arg, sizeof(*ldpc))) {
> -		ret = -EFAULT;
> -		goto err_out;
> -	}
> +	ldpc = memdup_user(arg, sizeof(*ldpc));
> +	if (IS_ERR(ldpc))
> +		return PTR_ERR(ldpc);
> 
>  	if (xsdfec->config.code == XSDFEC_TURBO_CODE) {
>  		ret = -EIO;
> --
> 2.6.2

Acked-by: Dragan Cvetic <dragan.cvetic@...inx.com>


Regards
Dragan