linux-kernel - Re: [PATCH] ASoC: ti: remove comparison to bool in omap_mcbsp_dai_set_dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <718c9a90-b5ff-f538-1152-c9b585095f3c@bitmer.com>
Date:   Sun, 26 Apr 2020 19:57:59 +0300
From:   Jarkko Nikula <jarkko.nikula@...mer.com>
To:     Jason Yan <yanaijie@...wei.com>, peter.ujfalusi@...com,
        lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, rafael.j.wysocki@...el.com, tglx@...utronix.de,
        alsa-devel@...a-project.org, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: ti: remove comparison to bool in
 omap_mcbsp_dai_set_dai_fmt()

On 4/26/20 12:42 PM, Jason Yan wrote:
> Fix the following coccicheck warning:
> 
> sound/soc/ti/omap-mcbsp.c:1188:5-11: WARNING: Comparison to bool
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  sound/soc/ti/omap-mcbsp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/ti/omap-mcbsp.c b/sound/soc/ti/omap-mcbsp.c
> index 3d41ca2238d4..0348963f4df7 100644
> --- a/sound/soc/ti/omap-mcbsp.c
> +++ b/sound/soc/ti/omap-mcbsp.c
> @@ -1185,7 +1185,7 @@ static int omap_mcbsp_dai_set_dai_fmt(struct snd_soc_dai *cpu_dai,
>  	default:
>  		return -EINVAL;
>  	}
> -	if (inv_fs == true)
> +	if (inv_fs)
>  		regs->pcr0 ^= FSXP | FSRP;
>  
Acked-by: Jarkko Nikula <jarkko.nikula@...mer.com>