lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 26 Apr 2020 21:31:52 +0200
From:   Philipp Rossak <embed3d@...il.com>
To:     Paul Cercueil <paul@...pouillou.net>,
        "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        James Hogan <jhogan@...nel.org>, Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Jonathan Bakker <xc-racer2@...e.ca>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        openpvrsgx-devgroup@...ux.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com, linux-mips@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v7 09/12] ARM: dts: sun6i: a31: add sgx gpu child node

Hi Paul,

On 26.04.20 14:53, Paul Cercueil wrote:
> 
> 
> Le ven. 24 avril 2020 à 22:34, H. Nikolaus Schaller <hns@...delico.com> 
> a écrit :
>> From: Philipp Rossak <embed3d@...il.com>
>>
>> We are adding the devicetree binding for the PVR-SGX-544-115 gpu.
>>
>> This driver is currently under development in the openpvrsgx-devgroup.
>> Right now the full binding is not figured out, so we provide here a
>> placeholder. It will be completed as soon as there is a demo available.
>>
>> The currently used binding that is used during development is more
>> complete and was already verifyed by loading the kernelmodule successful.
>>
>> Signed-off-by: Philipp Rossak <embed3d@...il.com>
>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>> ---
>>  arch/arm/boot/dts/sun6i-a31.dtsi | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi 
>> b/arch/arm/boot/dts/sun6i-a31.dtsi
>> index f3425a66fc0a..933a825bf460 100644
>> --- a/arch/arm/boot/dts/sun6i-a31.dtsi
>> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
>> @@ -1417,5 +1417,16 @@ p2wi: i2c@...3400 {
>>              #address-cells = <1>;
>>              #size-cells = <0>;
>>          };
>> +
>> +        gpu: gpu@...00000 {
>> +            compatible = "allwinner,sun8i-a31-sgx544-115",

looks like a copy paste error from my side this should be 
allwinner,sun6i-a31-sgx544-115

>> +                     "img,sgx544-115", "img,sgx544";
>> +            reg = <0x01c40000 0x10000>;
>> +            /*
>> +             * This node is currently a placeholder for the gpu.
>> +             * This will be completed when a full demonstration
>> +             * of the openpvrsgx driver is available for this board.
>> +             */
> 
> This node doesn't have clocks, so I don't see how it'd work.
> 
> Better delay the introduction of the GPU node for this board until you 
> know it works.
> 
> -Paul
This was already discuss in an earlier version that series that this 
should be delayed.

I will send a follow up patch series, as soon as I mainlined an other 
driver that I'm working on, which is required to properly describe the gpu.

Cheers
Philipp

Powered by blists - more mailing lists