Date:   Sun, 26 Apr 2020 11:10:48 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        CK Hu <ck.hu@...iatek.com>,
        Collabora Kernel ML <kernel@...labora.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] drm/mediatek: Remove debug messages for function calls

Hi, Enric:

Enric Balletbo i Serra <enric.balletbo@...labora.com> 於 2020年2月26日 週三 下午7:27寫道：
>
> Equivalent information can be nowadays obtained using function tracer.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
>
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 5 -----
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c  | 2 --
>  2 files changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index a236499123aa..882c690d3f13 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -192,7 +192,6 @@ static int mtk_crtc_ddp_clk_enable(struct mtk_drm_crtc *mtk_crtc)
>         int ret;
>         int i;
>
> -       DRM_DEBUG_DRIVER("%s\n", __func__);
>         for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) {
>                 ret = clk_prepare_enable(mtk_crtc->ddp_comp[i]->clk);
>                 if (ret) {
> @@ -212,7 +211,6 @@ static void mtk_crtc_ddp_clk_disable(struct mtk_drm_crtc *mtk_crtc)
>  {
>         int i;
>
> -       DRM_DEBUG_DRIVER("%s\n", __func__);
>         for (i = 0; i < mtk_crtc->ddp_comp_nr; i++)
>                 clk_disable_unprepare(mtk_crtc->ddp_comp[i]->clk);
>  }
> @@ -257,7 +255,6 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
>         int ret;
>         int i;
>
> -       DRM_DEBUG_DRIVER("%s\n", __func__);
>         if (WARN_ON(!crtc->state))
>                 return -EINVAL;
>
> @@ -298,7 +295,6 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
>                 goto err_mutex_unprepare;
>         }
>
> -       DRM_DEBUG_DRIVER("mediatek_ddp_ddp_path_setup\n");
>         for (i = 0; i < mtk_crtc->ddp_comp_nr - 1; i++) {
>                 mtk_ddp_add_comp_to_path(mtk_crtc->config_regs,
>                                          mtk_crtc->ddp_comp[i]->id,
> @@ -348,7 +344,6 @@ static void mtk_crtc_ddp_hw_fini(struct mtk_drm_crtc *mtk_crtc)
>         struct drm_crtc *crtc = &mtk_crtc->base;
>         int i;
>
> -       DRM_DEBUG_DRIVER("%s\n", __func__);
>         for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) {
>                 mtk_ddp_comp_stop(mtk_crtc->ddp_comp[i]);
>                 if (i == 1)
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 17f118ee0e57..4934834977b3 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -570,7 +570,6 @@ static int mtk_drm_sys_suspend(struct device *dev)
>         int ret;
>
>         ret = drm_mode_config_helper_suspend(drm);
> -       DRM_DEBUG_DRIVER("mtk_drm_sys_suspend\n");
>
>         return ret;
>  }
> @@ -582,7 +581,6 @@ static int mtk_drm_sys_resume(struct device *dev)
>         int ret;
>
>         ret = drm_mode_config_helper_resume(drm);
> -       DRM_DEBUG_DRIVER("mtk_drm_sys_resume\n");
>
>         return ret;
>  }
> --
> 2.25.0
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

Powered by blists - more mailing lists