linux-kernel - Re: [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support to lp55xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f149443-87f9-ca3f-e131-2b494cbfed84@ti.com>
Date:   Mon, 27 Apr 2020 13:17:16 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>, <pavel@....cz>
CC:     <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support
 to lp55xx

Jacek

On 4/26/20 11:07 AM, Jacek Anaszewski wrote:
> Hi Dan,
>
> One nit below.
>
> On 4/23/20 5:55 PM, Dan Murphy wrote:
>> Add multicolor framework support for the lp55xx family.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> ---
>>   drivers/leds/Kconfig                      |   1 +
>>   drivers/leds/leds-lp5521.c                |  14 +-
>>   drivers/leds/leds-lp5523.c                |  14 +-
>>   drivers/leds/leds-lp5562.c                |  13 +-
>>   drivers/leds/leds-lp55xx-common.c         | 178 +++++++++++++++++++---
>>   drivers/leds/leds-lp55xx-common.h         |  11 +-
>>   drivers/leds/leds-lp8501.c                |  14 +-
>>   include/linux/platform_data/leds-lp55xx.h |   8 +
>>   8 files changed, 207 insertions(+), 46 deletions(-)
>>
> [...]
>> diff --git a/drivers/leds/leds-lp55xx-common.h 
>> b/drivers/leds/leds-lp55xx-common.h
>> index b9b1041e8143..a9d7ba3f2fd1 100644
>> --- a/drivers/leds/leds-lp55xx-common.h
>> +++ b/drivers/leds/leds-lp55xx-common.h
>> @@ -12,6 +12,8 @@
>>   #ifndef _LEDS_LP55XX_COMMON_H
>>   #define _LEDS_LP55XX_COMMON_H
>>   +#include <linux/led-class-multicolor.h>
>> +
>>   enum lp55xx_engine_index {
>>       LP55XX_ENGINE_INVALID,
>>       LP55XX_ENGINE_1,
>> @@ -109,6 +111,9 @@ struct lp55xx_device_config {
>>       /* access brightness register */
>>       int (*brightness_fn)(struct lp55xx_led *led);
>>   +    /* perform brightness value to multiple LEDs */
>> +    int (*multicolor_brightness_fn)(struct lp55xx_led *led);
>
> Isn't some word missing here? IMO it should be rephrased.
> Maybe "write multi color brightness to hw" ?
>
But brightness_fn does not say write_brightness_fn so I think this would 
look weird to add write to the function name

Dan