linux-kernel - Re: [PATCH v2 08/12] mtd: rawnand: stm32_fmc2: use FIELD_PREP/FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Apr 2020 20:50:47 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Boris Brezillon <boris.brezillon@...labora.com>
Cc:     Christophe Kerello <christophe.kerello@...com>, <richard@....at>,
        <vigneshr@...com>, <lee.jones@...aro.org>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <tony@...mide.com>, marex@...x.de,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH v2 08/12] mtd: rawnand: stm32_fmc2: use
 FIELD_PREP/FIELD_GET macros

Hello,

Boris Brezillon <boris.brezillon@...labora.com> wrote on Thu, 16 Apr
2020 21:45:13 +0200:

> On Wed, 15 Apr 2020 17:57:32 +0200
> Christophe Kerello <christophe.kerello@...com> wrote:
> 
> > This patch removes custom macros and uses FIELD_PREP and FIELD_GET macros.  
> 
> Oh, nice. I didn't know about these macros. This could have saved me
> from defining a whole bunch of setters/getters in driver code...
> 
> 

Love these too! I will definitely use them in the future.

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

Thanks,
Miquèl