| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2b2e29ec-ebbf-3ee6-acc9-3722a2fabbfb@linux.intel.com>
Date: Mon, 27 Apr 2020 14:12:56 -0500
From: Richard Gong <richard.gong@...ux.intel.com>
To: Sudeep Holla <sudeep.holla@....com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: stratix10-svc: Drop unnecessary checking for
and populating /firmware/ node
Hi Sudeep,
In our dts, firmware is not under root node. You can refer to
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi for details.
This is why we need check and populate firmware node.
Regards,
Richard
On 4/23/20 3:11 AM, Sudeep Holla wrote:
> On Wed, Apr 22, 2020 at 04:50:00PM -0500, Richard Gong wrote:
>> Hi Sudeep,
>>
>> I tried and couldn't load stratix10-svc driver with your patch on kernel
>> 5.6.
>>
>
> What exactly do you mean by not loading stratix10-svc driver ?
> This patch doesn't change that part, the driver should still get loaded.
> The change may affect probing part if for some reason the devices for
> nodes under firmware are not populated which I still can't understand.
>
> Do you see any change under i/sys/devices/platform/firmware\:* with
> and without this change ?
>
> Lots of drivers removed the code similar to this patch after the Commit
> 3aa0582fdb82 ("of: platform: populate /firmware/ node from
> of_platform_default_populate_init()") and continue to work fine. I am
> interested to see what is different in stratix10-svc.
>
> --
> Regards,
> Sudeep
>
Powered by blists - more mailing lists