linux-kernel - Re: [PATCH] xfs: Use the correct style for SPDX License Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdcc8aa5a506ba9c6a3e6e68a7147161424985bf.camel@perches.com>
Date:   Mon, 27 Apr 2020 13:38:58 -0700
From:   Joe Perches <joe@...ches.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Nishad Kamdar <nishadkamdar@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xfs: Use the correct style for SPDX License Identifier

On Mon, 2020-04-27 at 12:40 -0700, Linus Torvalds wrote:
> On Mon, Apr 27, 2020 at 11:59 AM Joe Perches <joe@...ches.com> wrote:
> > There's no real reason not to prefer the latest versions
> > over the deprecated ones.
> 
> Joe, your pedantic approach is really hard to work with. Please work on it.

License text especially _should_ be pedantic and precise.

> The fact is, there *is * a reason to avoid the pedantic "change to new
> version" - pointless churn.

Have you *looked* at this proposed change?

It just changes // SPDX comments to /* */ in .h files.

It's generically useless churn as using the // style in .h files
was only for old and now unsupported compiler versions.

> We have a lot of the original style spdx markers, because those are
> what we started with. And changing them is pointless.

You and I (and apparently the SPDX group too as they deprecated it)
disagree a bit here.

> I know you love your scripts to change things around, but to everybody
> else it tends to be just extra work and noise.

Piecemeal changes aren't great.

Scripted changes can be very useful and I believe they
are significantly underutilized in this source tree.

cheers, Joe