linux-kernel - Re: [PATCH v2] md/raid0: add config parameters to specify zone layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <694314ee-bd47-94a4-4c39-038a792a56fe@akamai.com>
Date:   Mon, 27 Apr 2020 16:59:54 -0400
From:   Jason Baron <jbaron@...mai.com>
To:     Song Liu <songliubraving@...com>
Cc:     "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "neilb@...e.de" <neilb@...e.de>,
        "guoqing.jiang@...ud.ionos.com" <guoqing.jiang@...ud.ionos.com>,
        "agk@...hat.com" <agk@...hat.com>,
        "snitzer@...hat.com" <snitzer@...hat.com>,
        "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] md/raid0: add config parameters to specify zone layout



On 4/24/20 7:22 PM, Song Liu wrote:
> 
> 
>> On Mar 30, 2020, at 9:00 AM, Jason Baron <jbaron@...mai.com> wrote:
>>
>> Let's add some CONFIG_* options to directly configure the raid0 layout
>> if you know in advance how your raid0 array was created. This can be
>> simpler than having to manage module or kernel command-line parameters.
>>
>> If the raid0 array was created by a pre-3.14 kernel, use
>> RAID0_ORIG_LAYOUT. If the raid0 array was created by a 3.14 or newer
>> kernel then select RAID0_ALT_MULTIZONE_LAYOUT. Otherwise, the default
>> setting is RAID0_LAYOUT_NONE, in which case the current behavior of
>> needing to specify a module parameter raid0.default_layout=1|2 is
>> preserved.
>>
>> Cc: Guoqing Jiang <guoqing.jiang@...ud.ionos.com>
>> Cc: NeilBrown <neilb@...e.de>
>> Cc: Song Liu <songliubraving@...com>
>> Signed-off-by: Jason Baron <jbaron@...mai.com>
> 
> This patch looks good. However, I am not sure whether the user will 
> recompile the kernel for a different default value. Do you have real
> world use case for this?
> 
> Thanks,
> Song
> 

Hi Song,

Yes, we knew that all our raid0 arrays were created with >=3.14
kernels, and thus we wanted a way to specify the new layout without
needing to add to the command line or a module parameter. For us,
maintaining a CONFIG_* option is just simpler.

Thanks,

-Jason