linux-kernel - Re: [PATCH v6 2/5] PCI: Add Loongson PCI Controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200427144618.1e7a642a@flygoat-x1e>
Date:   Mon, 27 Apr 2020 14:46:18 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     Huacai Chen <chenhc@...ote.com>
Cc:     "open list:MIPS" <linux-mips@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Paul Burton <paulburton@...nel.org>, linux-pci@...r.kernel.org,
        devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 2/5] PCI: Add Loongson PCI Controller support

On Mon, 27 Apr 2020 14:29:34 +0800
Huacai Chen <chenhc@...ote.com> wrote:

> Hi, Jiaxun,
> 
> On Mon, Apr 27, 2020 at 2:06 PM Jiaxun Yang <jiaxun.yang@...goat.com>
> wrote:
> >
> > This controller can be found on Loongson-2K SoC, Loongson-3
> > systems with RS780E/LS7A PCH.
> >
> > The RS780E part of code was previously located at
> > arch/mips/pci/ops-loongson3.c and now it can use generic PCI
> > driver implementation.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> >
> > --
> > v2:
> >         - Clean up according to rob's suggestions
> >         - Claim that it can't work as a module
> > v3:
> >         - Fix a typo
> > v4:
> >         - More clean-ups: Drop flag check, use devfn
> > ---
> >  drivers/pci/controller/Kconfig        |  10 +
> >  drivers/pci/controller/Makefile       |   1 +
> >  drivers/pci/controller/pci-loongson.c | 251

[...]

> > +static const struct of_device_id loongson_pci_of_match[] = {
> > +       { .compatible = "loongson,rs780e-pci",
> > +               .data = (void *)(FLAG_CFG0), },
> > +       { .compatible = "loongson,ls2k-pci",
> > +               .data = (void *)(FLAG_CFG0 | FLAG_CFG1 |
> > FLAG_DEV_FIX), },
> > +       { .compatible = "loongson,ls7a-pci",
> > +               .data = (void *)(FLAG_CFG0 | FLAG_CFG1 |
> > FLAG_DEV_FIX), },  
> I suggest to use alpha-betical order here: ls2k, ls7a and rs780 at
> last.

Thanks for pointing out this minor issue.
I put rs780e at first at it appears to be the first system using this
driver.
If there is no more review suggestion I'll send out next revision very
soon. 

[...]

--
Jiaxun Yang