linux-kernel - Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: Select CONFIG_TIMER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50114298-7788-79bf-b9a8-26f399437c63@linaro.org>
Date:   Mon, 27 Apr 2020 09:00:06 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        linuxppc-dev@...abs.org, claudiu.beznea@...rochip.com
Subject: Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: Select
 CONFIG_TIMER_OF

On 26/04/2020 14:43, Michael Ellerman wrote:
> This driver is an OF driver, it depends on OF, and uses
> TIMER_OF_DECLARE, so it should select CONFIG_TIMER_OF.
> 
> Without CONFIG_TIMER_OF enabled this can lead to warnings such as:
> 
>   powerpc-linux-ld: warning: orphan section `__timer_of_table' from
>   `drivers/clocksource/timer-microchip-pit64b.o' being placed in
>   section `__timer_of_table'.
> 
> Because TIMER_OF_TABLES in vmlinux.lds.h doesn't emit anything into
> the linker script when CONFIG_TIMER_OF is not enabled.
> 
> Fixes: 625022a5f160 ("clocksource/drivers/timer-microchip-pit64b: Add Microchip PIT64B support")
> Cc: stable@...r.kernel.org # v5.6+
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
> ---

Applied, thanks

>  drivers/clocksource/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index f2142e6bbea3..f225c27b70f7 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -709,6 +709,7 @@ config MICROCHIP_PIT64B
>  	bool "Microchip PIT64B support"
>  	depends on OF || COMPILE_TEST
>  	select CLKSRC_MMIO
> +	select TIMER_OF
>  	help
>  	  This option enables Microchip PIT64B timer for Atmel
>  	  based system. It supports the oneshot, the periodic
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog