linux-kernel - Re: [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d141d9e7-5310-672a-9ffd-6be1b448261a@huawei.com>
Date:   Mon, 27 Apr 2020 10:17:29 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     <gregkh@...uxfoundation.org>, <hariprasad.kelam@...il.com>,
        <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
CC:     Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] staging: rtl8723bs: remove set but not used
 'pregistrypriv'

Sorry, it has already been fixed by YueHaibing. Please ignore this.

在 2020/4/26 17:43, Jason Yan 写道:
> Fix the following gcc warning:
> 
> drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable
> ‘pregistrypriv’ set but not used [-Wunused-but-set-variable]
>    struct registry_priv *pregistrypriv;
>                          ^~~~~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>   drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index 7853af53051d..e42d8c18e1ae 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -544,13 +544,9 @@ static void _InitRetryFunction(struct adapter *padapter)
>   
>   static void HalRxAggr8723BSdio(struct adapter *padapter)
>   {
> -	struct registry_priv *pregistrypriv;
>   	u8 valueDMATimeout;
>   	u8 valueDMAPageCount;
>   
> -
> -	pregistrypriv = &padapter->registrypriv;
> -
>   	valueDMATimeout = 0x06;
>   	valueDMAPageCount = 0x06;
>   
>