linux-kernel - Re: [PATCH] brcmfmac: remove comparison to bool in brcmf_fws

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Apr 2020 15:47:50 +0800
From:   Chi-Hsien Lin <chi-hsien.lin@...ress.com>
To:     Jason Yan <yanaijie@...wei.com>, arend.vanspriel@...adcom.com,
        franky.lin@...adcom.com, hante.meuleman@...adcom.com,
        wright.feng@...ress.com, kvalo@...eaurora.org, davem@...emloft.net,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        brcm80211-dev-list@...ress.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach()



On 04/26/2020 5:40, Jason Yan wrote:
> Fix the following coccicheck warning:
> 
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:2359:6-40:
> WARNING: Comparison to bool
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
Reviewed-by: Chi-hsien Lin <chi-hsien.lin@...ress.com>

> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
> index 8cc52935fd41..2b7837887c0b 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
> @@ -2356,7 +2356,7 @@ struct brcmf_fws_info *brcmf_fws_attach(struct brcmf_pub *drvr)
>   	fws->drvr = drvr;
>   	fws->fcmode = drvr->settings->fcmode;
>   
> -	if ((drvr->bus_if->always_use_fws_queue == false) &&
> +	if (!drvr->bus_if->always_use_fws_queue &&
>   	    (fws->fcmode == BRCMF_FWS_FCMODE_NONE)) {
>   		fws->avoid_queueing = true;
>   		brcmf_dbg(INFO, "FWS queueing will be avoided\n");
>