linux-kernel - Re: [PATCH] drm/amd/display: remove conversion to bool in dcn20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Apr 2020 10:03:01 +0200
From:   Christian König <christian.koenig@....com>
To:     Jason Yan <yanaijie@...wei.com>, harry.wentland@....com,
        sunpeng.li@....com, alexander.deucher@....com, David1.Zhou@....com,
        airlied@...ux.ie, daniel@...ll.ch, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: remove conversion to bool in dcn20_mpc.c

Am 27.04.20 um 08:37 schrieb Jason Yan:
> The '==' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c:455:70-75: WARNING:
> conversion to bool not needed here
>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c
> index de9c857ab3e9..9d7432f3fb16 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c
> @@ -452,7 +452,7 @@ void mpc2_set_output_gamma(
>   		next_mode = LUT_RAM_A;
>   
>   	mpc20_power_on_ogam_lut(mpc, mpcc_id, true);
> -	mpc20_configure_ogam_lut(mpc, mpcc_id, next_mode == LUT_RAM_A ? true:false);
> +	mpc20_configure_ogam_lut(mpc, mpcc_id, next_mode == LUT_RAM_A);
>   
>   	if (next_mode == LUT_RAM_A)
>   		mpc2_program_luta(mpc, mpcc_id, params);