linux-kernel - RE: [PATCH 2/3] hwrng: cctrng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR0802MB253351027A5B3236E31D1E9AE9AF0@DB6PR0802MB2533.eurprd08.prod.outlook.com>
Date:   Mon, 27 Apr 2020 08:56:38 +0000
From:   Hadar Gat <Hadar.Gat@....com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Ard Biesheuvel <ardb@...nel.org>, Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Stefan Wahren <wahrenst@....net>,
        Zaibo Xu <xuzaibo@...wei.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        Ofir Drang <Ofir.Drang@....com>, nd <nd@....com>
Subject: RE: [PATCH 2/3] hwrng: cctrng - change default to n


> -----Original Message-----
> From: Arnd Bergmann <arnd@...db.de>
> 
> On Mon, Apr 27, 2020 at 9:26 AM Hadar Gat <Hadar.Gat@....com> wrote:
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ardb@...nel.org>
> > > > +       default n
> > >
> > > 'default n' is the default so you can just remove the line
> >
> > Is this a guideline or just optional?
> > Personally I like things to be explicit and if allowed I prefer to keep this line.
> 
> It's a common convention, and we have had patches in the past that mass-
> removed those lines. I'd also just leave it out. It is generally well understood
> that all options default to 'n' unless specified otherwise.

Ok, I'll remove it.
Thanks for the explanation.

> 
>         Arnd