linux-kernel - Re: [PATCH] inotify: Fix error return code assignment flow.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200427101522.GD15107@quack2.suse.cz>
Date:   Mon, 27 Apr 2020 12:15:22 +0200
From:   Jan Kara <jack@...e.cz>
To:     youngjun <her0gyugyu@...il.com>
Cc:     Jan Kara <jack@...e.cz>, Amir Goldstein <amir73il@...il.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] inotify: Fix error return code assignment flow.

On Sun 26-04-20 07:33:16, youngjun wrote:
> If error code is initialized -EINVAL, there is no need to assign -EINVAL.
> 
> Signed-off-by: youngjun <her0gyugyu@...il.com>

Thanks. I've added the cleanup to my tree,

								Honza

> ---
>  fs/notify/inotify/inotify_user.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
> index 81ffc8629fc4..f88bbcc9efeb 100644
> --- a/fs/notify/inotify/inotify_user.c
> +++ b/fs/notify/inotify/inotify_user.c
> @@ -764,20 +764,18 @@ SYSCALL_DEFINE2(inotify_rm_watch, int, fd, __s32, wd)
>  	struct fsnotify_group *group;
>  	struct inotify_inode_mark *i_mark;
>  	struct fd f;
> -	int ret = 0;
> +	int ret = -EINVAL;
>  
>  	f = fdget(fd);
>  	if (unlikely(!f.file))
>  		return -EBADF;
>  
>  	/* verify that this is indeed an inotify instance */
> -	ret = -EINVAL;
>  	if (unlikely(f.file->f_op != &inotify_fops))
>  		goto out;
>  
>  	group = f.file->private_data;
>  
> -	ret = -EINVAL;
>  	i_mark = inotify_idr_find(group, wd);
>  	if (unlikely(!i_mark))
>  		goto out;
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR