linux-kernel - R: R: [PATCH v2 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <016c01d61c80$ba1358b0$2e3a0a10$@gmail.com>
Date:   Mon, 27 Apr 2020 12:43:43 +0200
From:   <ansuelsmth@...il.com>
To:     "'Viresh Kumar'" <viresh.kumar@...aro.org>
Cc:     "'Rob Herring'" <robh+dt@...nel.org>,
        "'Viresh Kumar'" <vireshk@...nel.org>,
        "'Andy Gross'" <agross@...nel.org>,
        "'Bjorn Andersson'" <bjorn.andersson@...aro.org>,
        "'Ilia Lin'" <ilia.lin@...nel.org>, "'Nishanth Menon'" <nm@...com>,
        "'Stephen Boyd'" <sboyd@...nel.org>,
        "'Rafael J. Wysocki'" <rjw@...ysocki.net>,
        "'Sricharan R'" <sricharan@...eaurora.org>,
        "'linux-arm-msm'" <linux-arm-msm@...r.kernel.org>,
        "'open list:THERMAL'" <linux-pm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: R: R: [PATCH v2 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq

> On 25-04-20, 00:19, ansuelsmth@...il.com wrote:
> > > On Wed, Apr 22, 2020 at 3:12 PM Ansuel Smith
> <ansuelsmth@...il.com>
> > > wrote:
> > > >
> > > > Update binding to new generic name "operating-points-v2-qcom-cpu"
> > > >
> > > > Fixes: a8811ec764f9 ("cpufreq: qcom: Add support for krait based
> socs")
> > > > Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt |
> 2
> > > +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/opp/qcom-nvmem-
> > > cpufreq.txt b/Documentation/devicetree/bindings/opp/qcom-nvmem-
> > > cpufreq.txt
> > > > index 64f07417ecfb..537e1774f589 100644
> > > > --- a/Documentation/devicetree/bindings/opp/qcom-nvmem-
> cpufreq.txt
> > > > +++ b/Documentation/devicetree/bindings/opp/qcom-nvmem-
> > > cpufreq.txt
> > > > @@ -19,7 +19,7 @@ In 'cpu' nodes:
> > > >
> > > >  In 'operating-points-v2' table:
> > > >  - compatible: Should be
> > > > -       - 'operating-points-v2-kryo-cpu' for apq8096, msm8996,
> msm8974,
> > > > +       - 'operating-points-v2-qcom-cpu' for apq8096, msm8996,
> > > msm8974,
> > > >                                              apq8064, ipq8064,
msm8960 and ipq8074.
> > >
> > > This is not how you fix the backwards compatibility issue pointed out
> > > on the Fixes reference.
> > >
> > > Rob
> >
> > Sorry but can you give some directive? Should I use the old binding and
> change
> > the driver to use it instead of the new one (and drop it) ?
> 
> It is not about the name of the binding, you can rename it to whatever
> you want. The kernel needs to keep supporting all the previous
> bindings, so we can keep on changing the kernel but keep the same
> bootloader (with earlier bindings).
> 
> --
> viresh

Ok but still I can't understand why this is not right. 
In 1/2 of this patchset I added the check for the old binding in the driver
and 
here I updated the Documentation with the new one. This way the kernel 
should support all the previous bindings and I can use the new better name.