linux-kernel - Re: [PATCH] lib/test_lockup.c: make test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b210d34-5dae-63c7-4fde-3332b99b0159@yandex-team.ru>
Date:   Mon, 27 Apr 2020 16:29:03 +0300
From:   Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
To:     Jason Yan <yanaijie@...wei.com>, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Cc:     Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] lib/test_lockup.c: make test_inode static

On 17/04/2020 10.40, Jason Yan wrote:
> Fix the following sparse warning:
> 
> lib/test_lockup.c:145:14: warning: symbol 'test_inode' was not declared.
> Should it be static?

Yep, but that's not so important.

> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>   lib/test_lockup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_lockup.c b/lib/test_lockup.c
> index ea09ca335b21..419fbaceba73 100644
> --- a/lib/test_lockup.c
> +++ b/lib/test_lockup.c
> @@ -142,7 +142,7 @@ module_param(reallocate_pages, bool, 0400);
>   MODULE_PARM_DESC(reallocate_pages, "free and allocate pages between iterations");
>   
>   struct file *test_file;

Why you're fixing only this warning? =)
test_file above should generate the same.

> -struct inode *test_inode;
> +static struct inode *test_inode;
>   static char test_file_path[256];
>   module_param_string(file_path, test_file_path, sizeof(test_file_path), 0400);
>   MODULE_PARM_DESC(file_path, "file path to test");
>