linux-kernel - Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y2qh9gzs.fsf@intel.com>
Date:   Mon, 27 Apr 2020 16:48:39 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Guru Das Srinagesh <gurus@...eaurora.org>
Cc:     linux-pwm@...r.kernel.org, David Collins <collinsd@...eaurora.org>,
        David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Subbaraman Narayanamurthy <subbaram@...eaurora.org>
Subject: Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro

On Fri, 24 Apr 2020, Guru Das Srinagesh <gurus@...eaurora.org> wrote:
> On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote:
>> On Tue, 21 Apr 2020, Guru Das Srinagesh <gurus@...eaurora.org> wrote:
>> > Since the PWM framework is switching struct pwm_state.duty_cycle's
>> > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
>> > to handle a 64-bit dividend.
>> >
>> > To: Jani Nikula <jani.nikula@...ux.intel.com>
>> > Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
>> > Cc: David Airlie <airlied@...ux.ie>
>> > Cc: Daniel Vetter <daniel@...ll.ch>
>> > Cc: Chris Wilson <chris@...is-wilson.co.uk>
>> > Cc: "Ville Syrjälä" <ville.syrjala@...ux.intel.com>
>> > Cc: intel-gfx@...ts.freedesktop.org
>> > Cc: dri-devel@...ts.freedesktop.org
>> >
>> 
>> Superfluous blank line.
>
> Will remove.
>
>> 
>> Anyway, please preserve the existing acks and reviews [1] so people
>> don't have to do it again.
>> 
>> BR,
>> Jani.
>> 
>> [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com
>
> I dropped your Acked-by as the patch had to changed to resolve a merge
> conflict when I rebased to tip. Could you please re-review this patch?

Reviewed-by: Jani Nikula <jani.nikula@...el.com>
Acked-by: Jani Nikula <jani.nikula@...el.com>


-- 
Jani Nikula, Intel Open Source Graphics Center