linux-kernel - Re: [PATCH v3 3/9] loop: Switch to set_capacity_revalidate_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200427145406.GC5490@lst.de>
Date:   Mon, 27 Apr 2020 16:54:06 +0200
From:   Christoph Hellwig <hch@....de>
To:     Martijn Coenen <maco@...roid.com>
Cc:     axboe@...nel.dk, hch@....de, ming.lei@...hat.com,
        narayan@...gle.com, zezeozue@...gle.com, kernel-team@...roid.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        maco@...gle.com, bvanassche@....org, Chaitanya.Kulkarni@....com,
        jaegeuk@...nel.org
Subject: Re: [PATCH v3 3/9] loop: Switch to
 set_capacity_revalidate_and_notify()

On Mon, Apr 27, 2020 at 09:42:16AM +0200, Martijn Coenen wrote:
>  	struct block_device *bdev = lo->lo_device;
>  
> -	set_capacity(lo->lo_disk, size);
>  	bd_set_size(bdev, size << SECTOR_SHIFT);
> +
>  	/* let user-space know about the new size */
> -	kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
> +	set_capacity_revalidate_and_notify(lo->lo_disk, size, false);

I'd drop the comment as that is pretty explicit with
set_capacity_revalidate_and_notify.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>