linux-kernel - Re: [PATCH v2][next] dmaengine: dw-edma: Check MSI descriptor before copying

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200427160103.GF56386@vkoul-mobl.Dlink>
Date:   Mon, 27 Apr 2020 21:31:03 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Alan Mikhak <alan.mikhak@...ive.com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, gustavo.pimentel@...opsys.com,
        dan.j.williams@...el.com, kishon@...com, maz@...nel.org,
        paul.walmsley@...ive.com
Subject: Re: [PATCH v2][next] dmaengine: dw-edma: Check MSI descriptor before
 copying

On 22-04-20, 18:58, Alan Mikhak wrote:
> From: Alan Mikhak <alan.mikhak@...ive.com>
> 
> Modify dw_edma_irq_request() to check if a struct msi_desc entry exists
> before copying the contents of its struct msi_msg pointer.
> 
> Without this sanity check, __get_cached_msi_msg() crashes when invoked by
> dw_edma_irq_request() running on a Linux-based PCIe endpoint device. MSI
> interrupt are not received by PCIe endpoint devices. If irq_get_msi_desc()
> returns null, then there is no cached struct msi_msg to be copied.
> 
> This patch depends on the following patch:
> [PATCH v2] dmaengine: dw-edma: Decouple dw-edma-core.c from struct pci_dev
> https://patchwork.kernel.org/patch/11491757/
> 
> Rebased on linux-next which has above patch applied.

These two para above should be added after s-o-b line as git-am skips
the lines after the marker. The above line are useful for applying but not
when applied. I have stripped these and applied the patch, thanks

-- 
~Vinod