[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200427165255.bjwkjobfzinzzlxb@holly.lan>
Date: Mon, 27 Apr 2020 17:52:55 +0100
From: Daniel Thompson <daniel.thompson@...aro.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: jason.wessel@...driver.com, gregkh@...uxfoundation.org,
kgdb-bugreport@...ts.sourceforge.net, mingo@...hat.com,
hpa@...or.com, bp@...en8.de, linux-serial@...r.kernel.org,
agross@...nel.org, tglx@...utronix.de, frowand.list@...il.com,
bjorn.andersson@...aro.org, jslaby@...e.com,
catalin.marinas@....com, corbet@....net, will@...nel.org,
Alexios Zavras <alexios.zavras@...el.com>,
Allison Randal <allison@...utok.net>,
Dave Martin <Dave.Martin@....com>,
Enrico Weigelt <info@...ux.net>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
James Morse <james.morse@....com>,
Mark Rutland <mark.rutland@....com>,
Masami Hiramatsu <mhiramat@...nel.org>,
jinho lim <jordan.lim@...sung.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/9] arm64: Add call_break_hook() to early_brk64() for
early kgdb
On Tue, Apr 21, 2020 at 02:14:43PM -0700, Douglas Anderson wrote:
> In order to make early kgdb work properly we need early_brk64() to be
> able to call into it. This is as easy as adding a call into
> call_break_hook() just like we do later in the normal brk_handler().
>
> Once we do this we can let kgdb know that it can break into the
> debugger a little earlier (specifically when parsing early_param's).
>
> NOTE: without this patch it turns out that arm64 can't do breakpoints
> even at dbg_late_init(), so if we decide something about this patch is
> wrong we might need to move dbg_late_init() a little later.
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
I haven't done any testing at this point (I'd hope to enable tests
for this in the test suite), however FWIW and just so you know I didn't
forget about this patch:
Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>
Daniel.
Powered by blists - more mailing lists