linux-kernel - Re: [PATCH] objtool: orc_gen: Fix memory leak in create_orc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88631822-874a-2c26-6661-5ee12c4f72eb@embeddedor.com>
Date:   Mon, 27 Apr 2020 12:28:51 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] objtool: orc_gen: Fix memory leak in create_orc_entry

Hi Josh,

On 4/27/20 09:44, Josh Poimboeuf wrote:
> On Mon, Apr 27, 2020 at 08:35:33AM -0500, Gustavo A. R. Silva wrote:
>> In case memory resources for rela were allocated, release them before
>> return.
>>
>> Addresses-Coverity-ID: 1462331 ("Resource leak")
>> Fixes: e81e07244325 ("objtool: Support Clang non-section symbols in ORC generation")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Hi Gustavo,
> 
> For performance reasons, our policy is to allow memory leaks in error
> and exit paths.  So you may want to turn off Coverity resource leak
> checking for objtool.
> 

Got it. That's good to know.

Thank you.
--
Gustavo