linux-kernel - Re: [PATCH -next] tty: serial: bcm63xx: fix missing clk_put() in bcm63xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73c4cebb-467b-e5d5-89bf-8a6fe29cf858@gmail.com>
Date:   Mon, 27 Apr 2020 10:29:58 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jiri Slaby <jslaby@...e.cz>, Zou Wei <zou_wei@...wei.com>,
        gregkh@...uxfoundation.org, bcm-kernel-feedback-list@...adcom.com,
        linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] tty: serial: bcm63xx: fix missing clk_put() in
 bcm63xx_uart



On 4/26/2020 11:19 PM, Jiri Slaby wrote:
> On 21. 04. 20, 14:31, Zou Wei wrote:
>> This patch fixes below error reported by coccicheck
>>
>> drivers/tty/serial/bcm63xx_uart.c:848:2-8: ERROR: missing clk_put;
>> clk_get on line 842 and execution via conditional on line 846
>>
>> Fixes: ab4382d27412 ("tty: move drivers/serial/ to drivers/tty/serial/")
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zou Wei <zou_wei@...wei.com>
>> ---
>>  drivers/tty/serial/bcm63xx_uart.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/bcm63xx_uart.c b/drivers/tty/serial/bcm63xx_uart.c
>> index 5674da2..ed0aa5c 100644
>> --- a/drivers/tty/serial/bcm63xx_uart.c
>> +++ b/drivers/tty/serial/bcm63xx_uart.c
>> @@ -843,8 +843,10 @@ static int bcm_uart_probe(struct platform_device *pdev)
>>  	if (IS_ERR(clk) && pdev->dev.of_node)
>>  		clk = of_clk_get(pdev->dev.of_node, 0);
>>  
>> -	if (IS_ERR(clk))
>> +	if (IS_ERR(clk)) {
>> +		clk_put(clk);
> 
> Why would you want to put an erroneous clk?

Doh, somehow I completely missed, you are right this does not look legit.
-- 
Florian